First implementation #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 23, 2025 17:59
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds the initial implementation of a Woopra component for Edgee, using Woopra’s HTTP Tracking API to forward page, custom track, and user-identify events via GET querystrings.
- Introduces
WoopraPayloadTrackandWoopraPayloadIdentifyfor serializing event and user data - Implements
Guestmethods insrc/lib.rsto map Edgee events to Woopra GET requests - Adds component manifest, documentation, Makefile, CI workflows, and basic tests
Reviewed Changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/woopra_payload.rs | Payload structs and custom serde serializers for Woopra prefixes |
| src/lib.rs | Component logic for page/track/user events and corresponding tests |
| edgee-component.toml | Component manifest with build and settings configuration |
| README.md | Usage guide, quick start, and configuration options |
| Makefile | Local build, test, and coverage targets |
| Cargo.toml | Package metadata and dependencies |
| CONTRIBUTING.md | Contributor guidelines |
| .github/workflows/wasm-build-release.yml | Release workflow for building and uploading the WASM artifact |
| .github/workflows/check.yml | CI checks: formatting, lint, build, and tests |
| .github/CODEOWNERS | Codeowners configuration |
Comments suppressed due to low confidence (2)
.github/workflows/check.yml:67
- This check is looking for
clickhouse.wasm, but the component buildswoopra.wasm. Update the filename to match.
if [ ! -f "./clickhouse.wasm" ]; then
src/woopra_payload.rs:292
- This comment precedes
serialize_cs_prefixedbut mentionsce_. Update it to reflect thecs_prefix.
// Helper function to serialize HashMap with "ce_" prefix
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
Author
|
I've tested this with: edgee component test --event-type track --settings project_name=demo.edgee.app --make-http-request
edgee component test --event-type page --settings project_name=demo.edgee.app --make-http-request
edgee component test --event-type user --settings project_name=demo.edgee.app --make-http-request
and it works great 👌 Note: the default test event uses a very old timestamp (from Feb 2025), so the event is ingested but doesn't show up in the real-time dashboard :) |
SachaMorard
approved these changes
Jun 24, 2025
Contributor
Author
|
Also tested on staging on demo.edgee.team and it's working great 👌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description of Changes
Details: